-
Notifications
You must be signed in to change notification settings - Fork 131
8355249: Remove the use of WMIC from the entire source code #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back tkurashige! A progress list of the required criteria for merging this PR into |
@kurashige23 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 71 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
Could anyone review this PR? |
|
/approval request Backporting this protects against the risk of future removal of WMIC. |
@kurashige23 |
/integrate |
@kurashige23 |
/sponsor |
Going to push as commit b407af9.
Your commit was automatically rebased without conflicts. |
@phohensee @kurashige23 Pushed as commit b407af9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code
JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported.
Original patch does not apply cleanly because JDK-8340311 is not backported to jdk21. For this reason, I modified Win8301247Test.java instead of WindowsHelper.java.
I confirmed that Win8301247Test.java passes on Windows Server 2022.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1912/head:pull/1912
$ git checkout pull/1912
Update a local copy of the PR:
$ git checkout pull/1912
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1912/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1912
View PR using the GUI difftool:
$ git pr show -t 1912
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1912.diff
Using Webrev
Link to Webrev Comment