Skip to content

8355249: Remove the use of WMIC from the entire source code #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kurashige23
Copy link
Member

@kurashige23 kurashige23 commented Jun 23, 2025

Hi all,

This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code

JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported.

Original patch does not apply cleanly because JDK-8340311 is not backported to jdk21. For this reason, I modified Win8301247Test.java instead of WindowsHelper.java.

I confirmed that Win8301247Test.java passes on Windows Server 2022.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8355249 needs maintainer approval

Issue

  • JDK-8355249: Remove the use of WMIC from the entire source code (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1912/head:pull/1912
$ git checkout pull/1912

Update a local copy of the PR:
$ git checkout pull/1912
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1912/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1912

View PR using the GUI difftool:
$ git pr show -t 1912

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1912.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2025

👋 Welcome back tkurashige! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@kurashige23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355249: Remove the use of WMIC from the entire source code

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 4458719a108f45d3744d47a6ea081fe9ec3e675e 8355249: Remove the use of WMIC from the entire source code Jun 23, 2025
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 23, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 23, 2025

Webrevs

@kurashige23
Copy link
Member Author

Could anyone review this PR?

@openjdk
Copy link

openjdk bot commented Jul 9, 2025

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@kurashige23
Copy link
Member Author

/approval request Backporting this protects against the risk of future removal of WMIC.
Original patch does not apply cleanly because JDK-8340311 is not backported to jdk21, so I Fixed a part of the original patch.
This fix constists of makefile fix and test fix, low risk.
I confirmed that Win8301247Test.java passes on Windows Server 2022.

@openjdk
Copy link

openjdk bot commented Jul 10, 2025

@kurashige23
8355249: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 10, 2025
@kurashige23
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 11, 2025
@openjdk
Copy link

openjdk bot commented Jul 11, 2025

@kurashige23
Your change (at version 1529d21) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 11, 2025

Going to push as commit b407af9.
Since your change was applied there have been 71 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2025
@openjdk openjdk bot closed this Jul 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 11, 2025
@openjdk
Copy link

openjdk bot commented Jul 11, 2025

@phohensee @kurashige23 Pushed as commit b407af9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants